Serialize sierra version to int not string #4252
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @maciektr and @orizi)
a discussion (no related file):
We'd like to land this change before 2.3.0-rc2 is released because technically this is breaking.
crates/cairo-lang-sierra/src/program.rs line 41 at r1 (raw file):
#[derive(Debug, Error)] #[error("Invalid version")]
Unsupported Sierra program version
Code quote:
Invalid version
maciektr
force-pushed
the
maciektr/sierra-serde
branch
from
1846356
to
fb734b2
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @mkaput and @orizi)
crates/cairo-lang-sierra/src/program.rs line 41 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
Unsupported Sierra program version
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr and @orizi)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @maciektr)
0f0b378
Serialize sierra version field to int instead of string (i.e.
version = 1instead ofversion = "1".For context on serde side see: serde-rs/serde#745
This change is